Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary usesContext from paragraph block #61008

Merged

Conversation

SantosGuillamot
Copy link
Contributor

What?

Remove unnecessary usesContext from paragraph block.

Why?

It doesn't seem to be used at all in the paragraph block.

If I am not mistaken, this was introduced as part of the first experiment of connecting blocks and custom fields: link. However, it was finally implemented using another solution, and it seems we didn't remove it.

How?

Just remove it from the block.json.

Testing Instructions

Tests should pass.

@SantosGuillamot SantosGuillamot added the [Type] Code Quality Issues or PRs that relate to code quality label Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in 03fc97a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8803311531
📝 Reported issues:

@gziolo
Copy link
Member

gziolo commented Apr 26, 2024

Nice catch 👍

@SantosGuillamot SantosGuillamot merged commit ea946fd into trunk Apr 28, 2024
65 checks passed
@SantosGuillamot SantosGuillamot deleted the update/remove-uses-context-in-paragraph-block branch April 28, 2024 08:32
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants