editPost: deprecate __experimentalPluginPostExcerpt #61188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +108 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
retrofox
changed the title
youknowriad
reviewed
Apr 29, 2024
| @@ -161,6 +160,6 @@ export function reinitializeEditor() { | |||
|
|
|||
| export { default as __experimentalFullscreenModeClose } from './components/header/fullscreen-mode-close'; | |||
| export { default as __experimentalMainDashboardButton } from './components/header/main-dashboard-button'; | |||
| export { __experimentalPluginPostExcerpt }; | |||
There was a problem hiding this comment.
This might be already used by third-party devs, so we should at least deprecate it and not remove it.
There was a problem hiding this comment.
not all code is in public repos/plugins :)
youknowriad
reviewed
Apr 29, 2024
|
It seems that after a third-party search above, the component is not used at all and since it's an experimental one, we might consider just deprecating it (without actually making it stable). Especially given that the UI for the excerpt panel is changing cc @ntsekouras |
We'd like to extend it in the Jetpack plugin. |
|
@retrofox did you consider replacing the existing panel instead? It seems like a potentially better approach? |
|
|
Yes, indeed that was the original and current implementation. |
retrofox
force-pushed
the
update/remove-experimental-prefix-from-excerpt-panel
branch
from
a603e9a
to
d1d4a7f
Compare
retrofox
changed the title
|
The problem with extending it is that it's not a really well defined API. What does extending it really means? Also removing is something we consistently support for panels so it's a good idea to keep the consistency between panels and not have an API for one panel adhoc. |
retrofox
changed the title
|
I've updated PR and its description. In short:
The question is should or shouldn't expose it |
retrofox
changed the title
|
Flaky tests detected in 82889e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8878173940
|
youknowriad
approved these changes
Apr 29, 2024
retrofox
deleted the
update/remove-experimental-prefix-from-excerpt-panel
branch
|
This breaks backward compatibility for an API exposed in a stable version of WordPress. I've opened #61219 as a follow up for replacing the noop function with a proper deprecation process that maintains backward compatibility. |
|
Thank you, Peter. We have created a follow-up and would appreciate it if you could take a look at it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It deprecates
__experimentalPluginPostExcerptcomponent in theeditPostpackage,and exposes thePluginPostExcerptcomponent in theeditorpackage.Follow up of #57096
Addressing this feedback.
Why?
Because we stopped using these prefixes.
How?
wp.editPost.__experimentalPluginPostExcerptfrom 6.6.Introducewp.editor.PluginPostExcerptfrom 6.6Testing Instructions
Check component functions
wp.editPost.__experimentalPluginPostExcerptis definedwp.editPost.__experimentalPluginPostExcerptis deprecatedTesting Instructions for Keyboard
Screenshots or screencast