-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Prep fix for placeholder background-blur filter. #61201
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +89 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Closing since the original issue was closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tentative fix for #52313. In a draft state because the scaling issue that caused the original bug has recently regressed: #52313 (comment)
The Placeholder component uses a backdrop-filter to make text legible inside, despite underlying backgrounds being present. When this is combined with a sub-pixel math, the Blink rendering engine has a way to render the blur that can cause a flickering effect. Here's a codepen demoing the issue: https://codepen.io/joen/pen/poBBKbZ?editors=1100 — hover the blurred element to see the flicker effect.
This PR fixes that by doing a few things:
The result looks like this:
Testing Instructions
This cannot yet be tested since trunk is missing the animation that caused it. But the way to repro is otherwise outlined in the referenced issue.