Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3rd party actions within composite action. #61211

Merged
merged 1 commit into from Apr 30, 2024

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Apr 29, 2024

What?

This updates the 3rd party actions used within the setup-node composite action. Unfortunately, it seems that Dependabot does not currently update workflows found outside of the .github/workflows directory, so these have fallen out of date.

This updates the 3rd party actions used within the `setup-node` composite action. Unfortunately, it seems that Dependabot does not currently update workflows found outside of the `.github/workflows` directory, so these have fallen out of date.
@desrosj desrosj self-assigned this Apr 29, 2024
Copy link

github-actions bot commented Apr 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in 3c3923f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8883214740
📝 Reported issues:

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@desrosj desrosj added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Apr 30, 2024
@desrosj
Copy link
Contributor Author

desrosj commented Apr 30, 2024

After creating this PR, a new feature was announced as public beta where you can specify multiple directories for a package ecosystem. It's unclear if this would solve the problem addressed here. Some more testing is needed. Let's merge this for now and try that out separately!

@desrosj desrosj merged commit 77f03d3 into trunk Apr 30, 2024
64 of 65 checks passed
@desrosj desrosj deleted the fix/gha-setup-node-composite-action branch April 30, 2024 15:28
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 30, 2024
@DaniGuardiola
Copy link
Contributor

Heads up that the Windows version of this CI task is failing for me, not sure if due to this change though: https://github.com/WordPress/gutenberg/actions/runs/8908331640/job/24463757246?pr=61138

@DaniGuardiola
Copy link
Contributor

This seems related: npm/cli#7308

@desrosj
Copy link
Contributor Author

desrosj commented May 1, 2024

It looks like your PR is the first one making a change to the package.json file after this PR was merged, which means it's the first one running the npm ci step.

There are some similar (though not exact) reports in the actions/setup-node repo. I did not see anything obvious looking at the release log there. Though the most recent version (4.0.2) did add support for arm64 on Windows.

I tried rolling that back in a test PR and it worked for me: https://github.com/WordPress/gutenberg/actions/runs/8911422697. I've gone and created #61289 to apply this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants