New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add test confirming that withFilters does not rerender #6135

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented Apr 12, 2018

It covers the case when filters added before the component was mounted.

Description

How Has This Been Tested?

Unit tests: npm run test.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.
Components: Add test confirming that withFilters does not rerender
It covers the case when filters added before the component was mounted.

@gziolo gziolo self-assigned this Apr 12, 2018

@gziolo gziolo requested a review from westonruter Apr 12, 2018

@gziolo gziolo merged commit e0342fa into master Apr 13, 2018

2 checks passed

codecov/project 44.56% remains the same compared to 004cb8b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/with-filters branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment