Tweak color pickers to use outlines and reduce spacing #61369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
richtabor
changed the title
Not 100% on this, but wanted to feel it out. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -46 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
May 4, 2024
There was a problem hiding this comment.
This PR also appears to be intended to reduce the palette space of the Duotone control, but the spacing between the palettes does not seem to be consistent.
I'm guessing one reason for this is that DuotoneControl has a hard-coded popover width. How about deriving the popover width from the popover padding, the size of the swatches, the spacing between swatches, and the number of swatches you want to display in a row, like the popover width for the ColorGradients component?
| width: ( $swatch-size * 6 ) + ( $swatch-gap * 5 ) + ( $panelPadding * 2 ); | ||
| width: ( $swatch-size * 5 ) + ( $swatch-gap * 6 ) + ( $panelPadding * 2 ); |
There was a problem hiding this comment.
Changing this logic creates spacing on the right side of the palette.
If we expect 6 palettes in a row as before, we should change this value from 12px to 8px:
tyxla
reviewed
May 9, 2024
There was a problem hiding this comment.
I think using outlines looks good and don't mind reducing the spacing, although I share the concerns @t-hamano had. As long as the spacing is consistent everywhere, we should be good. I did like the scaling effect more than just having an outline, though. Does it make sense to both scale and use outlines?
I also wonder if it makes sense to take it one step at a time? Working around spacing in one PR, and then work on the outlines vs scaling in another one, since this PR is doing a few things at the same time.
| transition: 100ms transform ease; | ||
| will-change: transform; | ||
| @include reduce-motion("transition"); | ||
|
|
||
| &:hover { | ||
| transform: scale(1.2); |
There was a problem hiding this comment.
I kind of liked the scaling though, and could live with the slightly blurred icon.
If the blurred scaling svg is a real problem, perhaps we can use a unicode check instead? Should be quite straightforward to change from svg to a <span>✓</span> - we'll only need to add some styles, like width and height to it, and change the selectedIconProps to provide style: { color } instead of fill.
richtabor
force-pushed
the
try/improve-color-pickers
branch
from
6ad9367
to
ebcabef
Compare
|
Flaky tests detected in ebcabef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9181282451
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Trying tiny optimizations for color palette items.
Testing Instructions
Screenshots or screencast