Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus currently selected block when entering canvas #61472

Merged
merged 3 commits into from
May 9, 2024
Merged

Focus currently selected block when entering canvas #61472

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45558f4
Fix scenario where blocks have been inserted but focus has not left t…
jeryj May 8, 2024
29df449
Clear last focused block when inserting new blocks
jeryj May 9, 2024
dc7a62f
Only clear last focus if we're selecting the block or focusing it on …
jeryj May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/writing-flow/use-tab-nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ export default function useTabNav() {
} else if ( hasMultiSelection() ) {
container.current.focus();
} else if ( getSelectedBlockClientId() ) {
getLastFocus()?.current.focus();
container.current
.querySelector(
`[data-block="${ getSelectedBlockClientId() }"]`
)
.focus();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellatrix suggested this, so it's good :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a non-hook util at some point similar to useBlockRef

} else {
setNavigationMode( true );

Expand Down
Loading