Update block inserter and library terminology and labels #61493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Focus] Accessibility (a11y)
|
Size Change: +320 B (+0.02%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/block-inserter-labeling
branch
from
327d470
to
6156a91
Compare
afercia
requested review from
ntwb,
nerrad,
ajitbohra,
draganescu,
adamziel,
kevin940726,
ellatrix,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
afercia
force-pushed
the
fix/block-inserter-labeling
branch
from
5405867
to
786e54e
Compare
|
I have no idea why that e2e test keeps failing with error message Any help would be appreciated, thanks @WordPress/gutenberg-core |
|
The snapshot title is automatically generated from the test title. The test title has changed in this PR, so the snapshot file name must also be updated. I pushed the fix, so this should pass. |
|
I have some reservation about this new terminology, but I'll share on the issue for now. |
Yeah I have reservations as well. This PR is an attempt to standardize on the terminology 'block inserter' for now but, as the discussion on the issue evolves, it appears 'block inserter' is not an appropriate naming any longer. |
🤦🏽♂️ thanks @t-hamano, I learned a new thing. |
|
There's some agreenent the terminology 'Block Inserter' isn't appropriate any longer so I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61483
What?
The term 'block inserter' is used inconsistently in user-facing strings. All text and label referencing it can be improved.
Why?
How?
Testing Instructions
interface-navigable-region interface-interface-skeleton__secondary-sidebarwhich is the ARIA landmark with role=region is now labeledBlock Inserterinstead ofBlock Library.Testing Instructions for Keyboard
Screenshots or screencast