Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use ESLint comma-dangle with always-multiline #615

Closed
wants to merge 1 commit into from
Closed

chore: Use ESLint comma-dangle with always-multiline #615

wants to merge 1 commit into from

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented May 3, 2017

Testing ESLint comma-dangle rule with always-multiline option

Ref #612

@ntwb
Copy link
Member Author

ntwb commented May 3, 2017

This might be a little too ambitious...

I'll take a closer look at the ESLint comma-dangle options http://eslint.org/docs/rules/comma-dangle#options

@nylen
Copy link
Member

nylen commented May 3, 2017

This might be a little too ambitious...

How so? This is exactly what I'd like to see here, though it is already needing a rebase. Hopefully the changes were prepared using eslint --fix or some other quick and easy method.

@nylen
Copy link
Member

nylen commented May 9, 2017

Closing in favor of #741.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants