[WIP] DataViews: Experiment with adding a Media page to the site editor #61516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Feature] Media
|
Size Change: +779 B (+0.04%) Total Size: 1.74 MB
鈩癸笍 View Unchanged
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
馃毀 馃毀 馃毀 馃毀 Note: this is an incredibly rough hack just to see where the DataViews work is up to, it is not intended as a final feature or feature proposal 馃毀 馃毀 馃毀 馃毀
This PR is inspired by similar earlier explorations in #56237, and copies the code for the
page-pagespart of the site editor and switches some variables over tomediato see how portable the current shape ofDataViewsis for a potential Media section of the site editor.Why?
This PR is mostly to satisfy my own curiosity for now, it is not a proposal of how things should work. But the broader "why" of a DataViews-based media library is discussed over in #55238
How?
To-do
Testing Instructions
For now, check out this PR, open the site editor and click on media. See if it allows you to open it.
Testing Instructions for Keyboard
Screenshots or screencast
2024-05-09.16.11.13.mp4
Related