-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert token-list package to TypeScript #61575
Closed
jpstevens
wants to merge
4
commits into
WordPress:trunk
from
jpstevens:update/convert-token-list-to-typescript
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
558a5dd
chore: convert token-list to typescript
jpstevens c3fdb0b
chore: convert token-list tests to typescript
jpstevens 8ec40f5
Merge branch 'WordPress:trunk' into update/convert-token-list-to-type…
jpstevens 9d4828d
Merge branch 'WordPress:trunk' into update/convert-token-list-to-type…
jpstevens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -64,7 +64,7 @@ describe( 'token-list', () => { | |||||||
|
||||||||
it( 'sets to stringified value', () => { | ||||||||
const list = new TokenList(); | ||||||||
list.value = undefined; | ||||||||
list.value = undefined as unknown as string; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For a case like this, I'd go with expect error. We know the type is wrong and we expect to have an error reported:
Suggested change
|
||||||||
|
||||||||
expect( list.value ).toBe( 'undefined' ); | ||||||||
} ); | ||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the types that have moved into TypeScript syntax should be removed from JSDoc annotations like this: