EntityProvider: Avoid remounts and simplify #61882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -67 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
stokesman
approved these changes
May 22, 2024
|
Flaky tests detected in dd7e118. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9198861064
|
|
Thanks for raising these issues @stokesman |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #61875
Alternative to #61874
What?
While debugging #61875 I noticed that the EditorProvider remounts its children when the "entity" changes (for instance when moving from a template to a template part). The reason for this is a poor implementation of the
EntityProvidercomponent. It was basically using some complex code to use a separate React context per entity.The current PR simplifies things a bit by using the same provider and hold all the "entity providers" in it. Personally, I think ultimately, we should seek to deprecate the EntityProviders entirely in favor of Block Context. It was a bad idea that stuck but that's for another time.
Testing Instructions
1- Open the site editor
2- Select a template part and click "edit"
3- The document bar should animate forward
4- Click "back" on the document bar and it should animate backwards.