InspectorControls: Text not displayed when "Show button text labels" is enabled #61949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
cc @DaniGuardiola who worked on #60560 |
|
Size Change: +23 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
DaniGuardiola
approved these changes
May 24, 2024
There was a problem hiding this comment.
Thank you @t-hamano, I agree that not relying in pseudo-elements is a better solution. The code looks good to me 👍
|
Thanks for the review! |
afercia
added
[Type] Regression
afercia
added
the
[Feature] Show button text labels
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…is enabled (WordPress#61949) * InspectorControls: Text not displayed when "Show button text labels" is enabled * Don't rely on pseudo-elements Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…is enabled (WordPress#61949) * InspectorControls: Text not displayed when "Show button text labels" is enabled * Don't rely on pseudo-elements Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61947
Seems to be caused by #60560
What?
This PR fixes an issue where tab text in InspectorControls is not displayed when "Show button text labels" is enabled.
Why?
When "Show button text labels" is enabled, text is often displayed using the following approach:
However, #60560 applied
opacity: 0;to thebeforepseudo-element, so the text is no longer visible.How?
Fortunately #60560 removed the
afterpseudo-element, so I changedbeforetoafter. But this is a temporary fix for WP6.6. It may not be an ideal approach as it may be affected by changes to theTabcomponent in the future. Overall, we will need to consider the implementation itself if "Show button text labels" is enabled, as discussed in #61763.Testing Instructions