Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressBar: Simplify default width implementation and make it more easily overridable #61976

Merged
merged 37 commits into from
May 29, 2024
Merged

ProgressBar: Simplify default width implementation and make it more easily overridable #61976

merged 37 commits into from
May 29, 2024

Commits on May 21, 2024

  1. Remove "experimental" designation for ProgressBar

    @fullofcaffeine
    fullofcaffeine committed May 21, 2024
    Configuration menu
    Copy the full SHA
    023e5c4 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Add optional width prop to override/set the progress bar track container

    @fullofcaffeine
    fullofcaffeine committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b1fe7cd View commit details
    Browse the repository at this point in the history

  2. Revert "Add optional width prop to override/set the progress bar trac… 

    …k container"

This reverts commit b1fe7cd.
    @fullofcaffeine
    fullofcaffeine committed May 22, 2024
    Configuration menu
    Copy the full SHA
    fe9129d View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Keep an unconstrained width by default, while allowing consumers to o… 

    …verride it with CSS
    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    64c72e2 View commit details
    Browse the repository at this point in the history

  2. Revert "Keep an unconstrained width by default, while allowing consum… 

    …ers to override it with CSS"

This reverts commit 64c72e2.
    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c88ece0 View commit details
    Browse the repository at this point in the history

  3. Make the component public

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ad0fff9 View commit details
    Browse the repository at this point in the history

  4. Update consumers to import the public component

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    dc299ed View commit details
    Browse the repository at this point in the history

  5. Expose docs for the now public ProgressBar component

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4c0b8fd View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0ff6637 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'trunk' into remove/wp-components-experimental-designati… 

    …on-for-progressbar
    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ad2fd28 View commit details
    Browse the repository at this point in the history

  8. Run docs:build after docs/manifest.js change

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    adf39a1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'trunk' into remove/wp-components-experimental-designati… 

    …on-for-progressbar

* trunk:
  Update Changelog for 18.4.1
  Remove package build-types directories when cleaning (#61939)
  Bump plugin version to 18.4.1
    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ceb2840 View commit details
    Browse the repository at this point in the history

  10. Remove remaining private usage of ProgressBar

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9b3db94 View commit details
    Browse the repository at this point in the history

  11. Small formatting fix in the changelog

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a219fa8 View commit details
    Browse the repository at this point in the history

  12. Add basic docs to the README

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1d22f24 View commit details
    Browse the repository at this point in the history

  13. Add jsdoc

    @fullofcaffeine
    fullofcaffeine committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b096ca4 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Formatting fix in README jsx block 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3af0985 View commit details
    Browse the repository at this point in the history

  2. Another formatting fix in README jsx block 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    846ccc0 View commit details
    Browse the repository at this point in the history

  3. YAFF (yet another formatting fix) in the README jsx 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    39b92a5 View commit details
    Browse the repository at this point in the history

  4. Improve wording in descripton of the value prop in the README 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3241379 View commit details
    Browse the repository at this point in the history

  5. YAFF: Missing semicolon in README jsx 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ff982fb View commit details
    Browse the repository at this point in the history

  6. YAFF: missing semicolon in jsx block in README 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    b0eca3f View commit details
    Browse the repository at this point in the history

  7. YAFF: missing semicolon in jsx block in README 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    59d46cc View commit details
    Browse the repository at this point in the history

  8. YAFF: use tab instead of spaces in jsx code block in README 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0832e40 View commit details
    Browse the repository at this point in the history

  9. Move export out of the HOC export section

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5ca947a View commit details
    Browse the repository at this point in the history

  10. Fix CHANGELOG: Move entry to the existing enhacements section

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    47183b7 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'trunk' into remove/wp-components-experimental-designati… 

    …on-for-progressbar
    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    eed1dba View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Spacing fix 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d132170 View commit details
    Browse the repository at this point in the history

  2. Sort import alphabetically

    @fullofcaffeine
    fullofcaffeine committed May 28, 2024
    Configuration menu
    Copy the full SHA
    43e1a57 View commit details
    Browse the repository at this point in the history

  3. Allow ProgressBar to have unconstrained width, which is disabled by… 

    … default

It has a default `max-width` of 160px, but allows consumers to
explicitely disable it so that it expands to fit the parent's width by
default. Consumers can then optionally set another width the way they
see fit via a custom `className`.
    @fullofcaffeine
    fullofcaffeine committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7a00da3 View commit details
    Browse the repository at this point in the history

  4. Revert "Allow ProgressBar to have unconstrained width, which is dis… 

    …abled by default"

This reverts commit 7a00da3.
    @fullofcaffeine
    fullofcaffeine committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a9c174b View commit details
    Browse the repository at this point in the history

  5. Update docs and add story to illustrate a custom width

    @fullofcaffeine
    fullofcaffeine committed May 28, 2024
    Configuration menu
    Copy the full SHA
    66e8223 View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG

    @fullofcaffeine
    fullofcaffeine committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3a95761 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge branch 'trunk' into improve/progress-bar-width-control

    @fullofcaffeine
    fullofcaffeine committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a076910 View commit details
    Browse the repository at this point in the history

  2. Simplify description in the story 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @fullofcaffeine @tyxla
    fullofcaffeine and tyxla committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2454c7a View commit details
    Browse the repository at this point in the history

  3. Improve jsdoc in story, do not encourage more customization than needed

    @fullofcaffeine
    fullofcaffeine committed May 29, 2024
    Configuration menu
    Copy the full SHA
    981ce6f View commit details
    Browse the repository at this point in the history

  4. Inherit the second story from the main template

    @fullofcaffeine
    fullofcaffeine committed May 29, 2024
    Configuration menu
    Copy the full SHA
    67d97df View commit details
    Browse the repository at this point in the history