Show shadow tool by default under global styles #61981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
vcanales
approved these changes
May 25, 2024
|
Size Change: -1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Thanks for the review! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61952
What?
This PR shows the shadow tool by default under global styles.
Why?
I think available tools should be displayed by default in the global styles, like the Typography panel and color panel.
How?
Changed the value of the
shadowproperty from false to true in theDEFAULT_CONTROLSvariable. This should not affect the block sidebar shadow panel.Testing Instructions
Go to the Site Editor > Global Styles > Blocks > Button
The shadow panel should be visible by default.
Open the block sidebar for the Button block. Shadow panels should not be visible by default.
(Additional testing) In the Button block, make the following changes to display the shadow panel by default:
In the Button block's sidebar, the shadow panel should be visible by default.