useUploadMediaFromBlobURL: Prevent duplicate uploads in StrictMode #62059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +169 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
[Feature] Media
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
youknowriad,
jsnajdr,
tyxla and
t-hamano
and removed request for
ajitbohra
|
Flaky tests detected in d75e15b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9268620337
|
|
Do you think we can build a temporary |
|
@youknowriad, I was just looking into that and now I'm unsure if that will solve our use case. The returned callback from |
|
Maybe this bug is a signal that we should be looking for a better solution than the
There isn't any other use case for createBlock( 'core/image', {
url: await uploadFile( file )
} )Also this is another example where the block is not "headless", i.e., the |
|
@jsnajdr, I agree that would be a better solution. This is a known shortcoming, and there's an open discussion in #49466.
There was an issue or PR for a similar proposal, and if I recall correctly, the issue was making transformations async. I'll try to find it later and link it here for the reference. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…ordPress#62059) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ordPress#62059) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR added an extra check to the
useUploadMediaFromBlobURLto prevent triggering the upload process multiple times in development mode.The bug was discovered via #61943.
Why?
The hook didn't account for the double effect run in the
StrictMode; the effect can't cancel the in-flight upload via the cleanup method.P.S. The hooks should use theuseEffectEventhook when it ships in React.Testing Instructions
SCRIPT_DEBUGis set to true.StrictModefor the post editor.POSTrequest is triggered to upload the image.StrictMode patch
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-05-28.at.15.35.18.mp4