Fixed Media Text Block Issue : When crop image to fill is enabled, the image in nested media & text blocks does not show #62182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
narenin
changed the title
t-hamano
reviewed
May 31, 2024
|
@t-hamano Thanks for the feedback. I have implemented the suggestions, please check. |
t-hamano
added
[Type] Bug
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…e image in nested media & text blocks does not show (WordPress#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
|
Should this be backported for WP 6.6? If so, please add the |
|
This issue isn't new to WP6.6, but I think it's a great fix, so let's backport it to WP6.6. |
t-hamano
added
the
Backport to WP 6.6 Beta/RC
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…e image in nested media & text blocks does not show (#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…e image in nested media & text blocks does not show (#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…e image in nested media & text blocks does not show (WordPress#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.6 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix: #62166
When the media & text block has an image (or featured image), and the setting "Crop image to fill" is enabled,
and another media & text block is added in the content area, the image of that second media & text block is hidden. It is hidden by the CSS from the first (outer) media & text block.
Why?
This will fixed the issue which occur when crop image to fill is enabled, the image in nested media & text blocks.
How?
I have resolved this by adding
>to the relevant CSS selectors.Testing Instructions