Style Book: allow activation when the canvas mode is "view" #62212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…', or the editor view is not currently editable) when rendering the editor canvas container slot is a regression. Removing.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
commented
Jun 3, 2024
| @@ -160,7 +160,7 @@ export default function EditorInterface( { | |||
|
|
|||
| <EditorContentSlotFill.Slot> | |||
| { ( [ editorCanvasView ] ) => | |||
| ! isPreviewMode && editorCanvasView ? ( | |||
| editorCanvasView ? ( | |||
There was a problem hiding this comment.
The only "views" are revisions and style book.
Style book is the only "view" that can be activated in edit and view mode.
This PR reverts the functionality to how it was before. This condition could be tightened up in this PR to check whether the style book is open too, but I don't believe it's necessary.
@youknowriad gave some great advice over in https://github.com/WordPress/gutenberg/pull/62146/files#r1621762342 about how the whole view system could be refactored. I haven't digested it all yet, but maybe things could be improved iteratively and we just fix the regression here as it is.
There was a problem hiding this comment.
That change is fine by me 👍
|
Size Change: -1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Jun 3, 2024
youknowriad
added
the
Backport to WP 6.6 Beta/RC
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…', or the editor view is not currently editable) when rendering the editor canvas container slot is a regression. Removing. (WordPress#62212) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…', or the editor view is not currently editable) when rendering the editor canvas container slot is a regression. Removing. (#62212) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…', or the editor view is not currently editable) when rendering the editor canvas container slot is a regression. Removing. (#62212) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…', or the editor view is not currently editable) when rendering the editor canvas container slot is a regression. Removing. (WordPress#62212) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.6 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62204
What?
Remove the
! isPreviewModecheck before rendering contents of theeditorCanvasViewslot.The effect is that the style book can be opened from the global styles side bar in preview mode when switching style variations.
Why?
Before #62146, there was no check for preview mode when rendering the editor canvas container slot.
What is preview mode?
It's another way of saying
canvasMode === 'view', which is a another way of saying that the editor view is not currently editable.Thanks to @t-hamano for catching it.
Testing Instructions
2024-06-03.12.16.11.mp4