-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test using Node.js 22.x. #62341
Test using Node.js 22.x. #62341
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
You can probably land this with admin privileges, but we'll need to update the required checks in this repo accordingly. Right now there are required checks like Is it possible to define the required checks with globs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Seems like pattern matching is not an option for status checks. Probably one of my least favorite GH features because of this reason. Thanks for pointing it out. I think the best path forward is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it’s expected that GitHub would complain about the required CI jobs. It’s often the case that landing such changes require admin permissions.
The proposed steps to land this seem reasonable 👍 |
@gziolo could you take a look at the branch rules for |
It looks good and seems to work correctly. I checked in the newly open PR: #62370. |
* Test using Node.js 22.x. * Update Node.js in create block workflow. --------- Co-authored-by: desrosj <desrosj@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
What?
This updates the version of Node.js used in test matrices from
20.x
&21.x
to20.x
&22.x
.Why?
Version 20.0.0 was released on April 4, 2024 and is the new "current" release for Node.js. The latest version for this major release is is 22.2.0.
21.x has now reached end-of-life. In Node.js, odd numbered versions are not promoted to (Active|Maintenance) LTS. Instead they serve only as the current release for ~6 months.
Some of our test workflows are currently set up to run on 20.x (the current minimum required version of Node.js to contribute) and the latest current version (now 22.x) as a way to proactively test against new versions that become available with the aim to make increasing the minimum version required more easily in the future.
Testing Instructions
These workflows should not be considered all inclusive testing. Contributors can run
22.x
locally and report any additional problems that are discovered.A full list of the changes in 22.0.0 can be found in the project's changelog.