Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version for flaky test reporter #62401

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jun 7, 2024

What?

PR updates the Node version for the flaky test reporter action.

Why?

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Testing Instructions

It shouldn't generate a notice in the e2e tests summary.

@Mamaduka Mamaduka added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jun 7, 2024
@Mamaduka Mamaduka self-assigned this Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka
Copy link
Member Author

Mamaduka commented Jun 7, 2024

@kevin940726, are there other places I need to update the Node version for this action? Because the notice is still displayed - https://github.com/WordPress/gutenberg/actions/runs/9413245504?pr=62401

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevin940726
Copy link
Member

@kevin940726, are there other places I need to update the Node version for this action? Because the notice is still displayed - https://github.com/WordPress/gutenberg/actions/runs/9413245504?pr=62401

Because it checkouts to trunk to run the action. I believe the warning will go away once we merge this to trunk!

@Mamaduka Mamaduka merged commit 1c6c693 into trunk Jun 12, 2024
66 checks passed
@Mamaduka Mamaduka deleted the update/flaky-test-reporter branch June 12, 2024 07:39
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 12, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants