Bootstrap the dashboard layout #62409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Experimental
youknowriad
requested review from
mcsf,
jsnajdr,
stokesman,
jorgefilipecosta and
fabiankaegy
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Jun 7, 2024
|
|
||
| const { RouterProvider } = unlock( routerPrivateApis ); | ||
| const { GlobalStylesProvider } = unlock( editorPrivateApis ); | ||
|
|
||
| function AppLayout() { |
There was a problem hiding this comment.
I basically extracted the site editor specific code from the "Layout" component using this wrapper. Now the Layout component is agnostic from the site editor content.
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/posts/load.php |
youknowriad
commented
Jun 7, 2024
| preview: undefined, | ||
| mobile: <Page>Welcome to Posts</Page>, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
@jsnajdr I wish we can declare the routes of the site editor in a static way like this with an extra "path" or something.
For now, having a useLayoutArea hook for the site editor and another one for this new experimental page... works. But there's something to be done here.
There was a problem hiding this comment.
We'll need to have a hook similar to useLayoutAreas here to get params from location later, right?
|
Size Change: +10.9 kB (+0.62%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5b3503b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9415780208
|
5 tasks
youknowriad
force-pushed
the
add/posts-dashboard-layout
branch
from
5b3503b
to
8d85095
Compare
ntsekouras
approved these changes
Jun 11, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #62371
What?
This PR just reuses the "Layout" component from the site editor in the new posts dashboard. It doesn't do a lot aside setting things in order to be able to add "routes" and "pages" for the posts dataviews...
The results for the moment is as shown in the screenshot.
Testing Instructions
1- Check that the site editor continues to work as expected.
2- Check that the experimental "posts" page looks like the screenshot above (you can use the command palette if you want :P)