Sort spacing sizes when all slugs begin numerically #62567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +8 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ajlende
added
the
Backport to WP 6.6 Beta/RC
ajlende
commented
Jun 14, 2024
| 1 | ||
| ) { | ||
| // Using numeric slugs opts-in to sorting by slug. | ||
| if ( sizes.every( ( { slug } ) => /^[0-9]/.test( slug ) ) ) { |
There was a problem hiding this comment.
I have this just checking that it starts with a number, allowing slugs like 50-medium to be sorted, but maybe it would make more sense to only sort slugs that are completely numeric.
|
Flaky tests detected in bfcc4cf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9510958444
|
scruffian
approved these changes
Jun 14, 2024
justintadlock
approved these changes
Jun 14, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: justintadlock <greenshady@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: justintadlock <greenshady@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: justintadlock <greenshady@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 8ffc66f |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: justintadlock <greenshady@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the sorting heuristic for
spacingSizesfrom having more than one origin to all slugs from all origins beginning numerically.Removes the numeric requirement for slugs in the schema.
Why?
Fixes #62520
How?
#62520 (comment)
Testing Instructions
Try numeric and non-numeric slugs with and without defaults enabled to see if sorting happens when you would expect.
Testing Instructions for Keyboard
Screenshots or screencast