Fix e2e tests in dev mode #62642
Merged
Fix e2e tests in dev mode #62642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +220 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Originally reported in Slack. Since #62398,
npm run devno longer produces commonJS code, which breaks running e2e tests in dev mode. This PR fixes that with a duct-tape for now.Why?
It's convenient to run e2e tests locally when in development mode.
How?
It seems like we are only using
@wordpress/keycodesfor now in thee2e-test-utils-playwrightpackage. We only have to inline some of the code to fix this issue. Note that this might not be the final solution though, but seems the easiest for now.We should probably look into other cases as well.
Testing Instructions
npm run dev.npm run test:e2e -- --ui