Fix: a11y text for site editor

[up1512001]

What?

• updated aria label text as site text

Why?

Fixes #62644

How?

• using site title for aria label label={ decodeEntities( siteTitle ) }

Screenshots or screencast

Screen.Recording.2024-06-18.at.23.00.18.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[youknowriad]

I think @richtabor worked on this recently, so this might be a design regression a bit.

[afercia]

Please see inline comments.

[up1512001]

@afercia addressed your feedback please review the PR.

[afercia]

Suggested change

	vertical-align: middle;
	vertical-align: middle;
	transition: opacity 0.1s ease-in-out;
	@include reduce-motion("transition");

[afercia]

I think this color needs to be kept at least for the :active state otherwise when clicking the link, the text will become black on a black background. Screenshot:

[afercia]

Also, the button padding should be adjusted to keep the current spacing as much as possible. Screenshot with comparison of current trunk and this PR:

[up1512001]

@afercia updated as per your feedback. please check.

[richtabor]

I think @richtabor worked on this recently, so this might be a design regression a bit.

Yes, let's resolve the a11y feedback apart from icon changes.

The ExternalLink component has been updated to leverage the ↗ unicode character. This is intended to share the same DNA as that component, as it is also a text only external link.