Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Comments Block Centre alignment is not working properly #62667

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

snehapatil2001
Copy link
Contributor

@snehapatil2001 snehapatil2001 commented Jun 18, 2024

Fixes #62503

This PR addresses the issue where the Latest Comments block's center alignment was not functioning correctly. By applying a flexbox layout, the content within the block is now properly centered.

What?

Fixed center alignment issue in Latest Comments block.

Why?

To ensure content within the block is properly centered when aligned to the center.

How?

Applied a flexbox layout to achieve proper center alignment.

Testing Instructions

  1. Add the Latest Comments block to a post/page.
  2. Change the alignment to center.
  3. Verify that the comments content (meta and excerpt) is centered horizontally.
  4. Test responsiveness on different screen sizes to ensure consistent centering.

Testing Instructions for Keyboard

  1. Navigate to the Latest Comments block using keyboard navigation.
  2. Change alignment to center using keyboard shortcuts.
  3. Verify that the content is visually centered and accessible.

Screenshots or screencast

Before:

Screenshot 2024-06-19 at 2 43 04 PM

After:

Screenshot 2024-06-19 at 2 40 40 PM

Copy link

github-actions bot commented Jun 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: snehapatil2001 <snehapatil02@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: pitamdey <pitamdey@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 18, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @snehapatil2001! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@akasunil akasunil added [Block] Latest Comments Affects the Latest Comments Block [Type] Bug An existing feature does not function as intended labels Jun 19, 2024
@afercia
Copy link
Contributor

afercia commented Jun 19, 2024

Thanks for your PR @snehapatil2001
When you have a chance, could you please follow the format of the PR template I re-added in the PR description? Most importantly, please add the testing instructions.

@snehapatil2001
Copy link
Contributor Author

@afercia Updated the PR description, let me know if I have missed something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Comments Affects the Latest Comments Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest Comments Block Centre alignment is not working properly
3 participants