-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit pattern shuffling to theme and user patterns only #62677
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +391 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Flaky tests detected in 68b1a33. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9584903773
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described. I'm not sure if this is a better experience though IMO :)
Co-authored-by: Ben Dwyer <ben@scruffian.com>
What?
Closes #60135
This limits shuffling to only patterns added by the theme or the user
Why?
Core patterns or pattern directory patterns may not fit the design of the theme. By excluding them we make the shuffling more consistent with the theme's design
How?
By checking the source of the pattern. The condition will exclude all patterns from the pattern directory (testing on TT4 I could see patterns with the source
pattern-directory/core
andpattern-directory/featured
), all core patterns (such as the social icons one) and keeppattern-directory/theme
patterns (TT4 includes two of those)Testing Instructions