Styles: lower specificity of figcaption style to allow theme.json override #62689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
artemiomorales and
michalczaplinski
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +186 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jun 20, 2024
talldan
added
the
Backport to WP 6.6 Beta/RC
|
I think we'll have to do this for all other blocks as well. |
|
@talldan Sorry, I forgot your prop 😓 |
ellatrix
added a commit
that referenced
this pull request
Jun 25, 2024
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 6a7e443 |
ellatrix
added
Backported to WP Core
ellatrix
added a commit
that referenced
this pull request
Jun 25, 2024
2 tasks
Shouldn't the figcaption in the gallery block have a lower specificity too? gutenberg/packages/block-library/src/gallery/style.scss Lines 46 to 69 in f6133cd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
editor.scss. So this PR adjusts that.Why?
Fixes #62679.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast