Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for origin and issue warning if origin is incorrect. #62708

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

kt-12
Copy link
Member

@kt-12 kt-12 commented Jun 20, 2024

Earlier, before https://core.trac.wordpress.org/ticket/61112, just after the filter, we used to recreate the WP_Theme_JSON_Data_Gutenberg object passing the correct origin. Removing that introduced a risk for someone using the filter to accidentally create a new object with a wrong origin.

What?

The PR introduces an origin check after the filter.

Why?

There is a high chance that someone using the filter can set a wrong origin. Earlier this wasn't a risk as object was recreated with right origin.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@kt-12 kt-12 requested a review from spacedmonkey as a code owner June 20, 2024 15:02
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kt-12 <thekt12@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joemcgill joemcgill self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants