Fix lock modal dialog accessibility and semantics #62795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -10 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
alexstine
reviewed
Jun 25, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
afercia
force-pushed
the
fix/lock-modal-dialog-accessibility-semantics
branch
from
628720c
to
5d02458
Compare
t-hamano
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
I think the code is absolutely fine. NVDA's speech has changed to the following:
When the Lock modal is opened
Before:
Lock Navigation
heading level 1 Lock Navigation
button Close
Choose specific attributes to restrict or lock all available options.
grouping check box not checked Lock all
list with 3 items check box not checked Restrict editing
check box not checked Disable movement
check box not checked Prevent removal out of list
check box not checked Apply to all blocks inside out of grouping
button Cancel
button Apply
After:
Lock Navigation
heading level 1 Lock Navigation
button Close
grouping Choose specific attributes to restrict or lock all available options.
list with 1 item check box not checked Lock all list with 3 items check box not checked Restrict editing
check box not checked Disable movement
check box not checked Prevent removal out of list out of list
check box not checked Apply to all blocks inside out of grouping
button Cancel
button Apply
When the form elements are focused in order
Before:
Lock all grouping Lock all check box not checked
list with 3 items Restrict editing check box not checked
Disable movement check box not checked
Prevent removal check box not checked
Apply to all blocks inside check box not checked
After:
Choose specific attributes to restrict or lock all available options. grouping list with 1 item Lock all check box not checked
list with 3 items Restrict editing check box not checked
Disable movement check box not checked
Prevent removal check box not checked
Apply to all blocks inside check box not checked
|
Thanks all for your feedback and review. Ideally, the legend text should be a little more concise. The current one is too long: It's also unclear what the difference between attributes and options is. Actually, I don't think it really matters for users. If anyone can think of a shorter, simpler, text to name the group I'd gladly update it. |
I agree with this, but I can't think of a good copy right now 😅 Perhaps we can address this in a follow-up. |
|
I will split the wording into a separate issue, as I think the options naming could be improved as well. |
afercia
force-pushed
the
fix/lock-modal-dialog-accessibility-semantics
branch
from
5d02458
to
c6efdcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47248
What?
Labeling and semantics of the block lock modal dialog can be improved.
Why?
How?
Testing Instructions
<fieldset>element with a<legend>element that gives the fieldset a name.common.css.Testing Instructions for Keyboard
Screenshots or screencast
Screenshots before and after: