Components: upgrade Ariakit to latest #62947
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
added
the
[Type] Code Quality
DaniGuardiola
requested review from
mirka,
jsnajdr,
ciampo and
tyxla
and removed request for
ajitbohra
|
Size Change: +1.64 kB (+0.09%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Since there are no evident breaking changes that affect us on changelog inspection, but we have many failing tests, I'm going to take another strategy. I will go version by version and addressing any errors step by step. |
|
Also ping @WordPress/gutenberg-components if you can take a look at failing tests in CI and see if anything rings a bell or if you have any ideas. Since you're more familiar with the code, you might be able to save me some research in some cases. |
|
Flaky tests detected in 430522f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9703427176
|
Mamaduka
added
[Feature] UI Components
|
Happy to pair on this one whenever you've got time to work on it |
For some of the tests, it might be as easy as replacing the to: Note that historically when tabbing, we needed to do |
That has definitely proven true for other ariakt-based components like |
|
I have some unpushed fixes like that, let me push soon and I'll let y'all know so we can figure out any remaining cases. |
|
Flagging related conversation in #63433 (comment) |
|
After a pairing session with @DaniGuardiola , we determined that the test failures caused by the |
|
Quoting my comment from the other PR to ensure it doesn't get lost in the conversation:
|
|
Also quoting this other suggestion from Diego:
|
…pgrade/ariakit
Have we tried this already, and whether it has an effect on the Also, it looks like the branch is quite behind and needs to be rebased. Some of the failures are in the v1 |
|
@tyxla unless I missed something, the branch was synced with trunk yesterday.
I'm also trying our |
out of experience, we'd usually wait for some |
This. Or historically it's been |
|
Also adding a link to this convo that I found while reviewing old notifications — we should be able to remove that timer in the tooltip tests after updating to latest ariakit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved over from personal repo, see original PR: #60992
Went through all breaking changes in all relevant versions. Only 0.4.0 had breaking changes (it's a "pseudo-major", so it makes sense). Here's a summary of those changes, TL;DR it doesn't seem like we need to do anything about them, and we just need to test enough to be confident in the upgrade.
packages/dataviews/src/search-widget.tsx, unaffected.There is another change not considered "breaking" by Ariakit, but it deserves consideration:
Previously, Ariakit added
aria-describedByto tooltip anchors. Now, it doesn't, and users are responsible for making anchors accessible, see: https://ariakit.org/components/tooltip#tooltip-anchors-must-have-accessible-namesUpdate 1 - Initial state of tests as of v0.3.13 (79fa288):
After turning a couple of
getByRoleintoawait findByRole(179f374):(sometimes it fails on 16 tests, not sure which one yet)
Remaining work: