Used IconButton on breadcrumbs to increase accessibility. #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
force-pushed
the
update/used-icon-button-in-breadcrumbs
branch
from
fe8cb22
to
506bf1a
Compare
jorgefilipecosta
force-pushed
the
update/used-icon-button-in-breadcrumbs
branch
from
506bf1a
to
27e119e
Compare
|
I will make further changes in this area, so I'm merging this one to avoid conflicts. If there is any other improvement needed in this area, feedback is welcome and can be addressed in the follow-up PR's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the usage of Button + Dashicon with IconButton in order to increase accessibility. IconButton label is used as aria-label.
It looks like uid prop was passed to dashicon by mistake as the component does not do anything with this prop.
How has this been tested?
Add a paragraph inside a column, hover the paragraph and verify it is still possible to use the select parent button to select the parent block.