Remove wrap text setting in button block

[samikeijonen]

Description

There is a Wrap text setting in Button block. However it doesn't do anything. It doesn’t add any classes and no visual change in the editor or front-end. See issue #6563.

How has this been tested?

Tested changing other button settings.

Screenshots

Note from screenshot. There is kind of weird looking "double" border now.

Types of changes

Remove wrap text setting in button block

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[aduth]

Previously: #1512

Is #1473 an issue with or without these changes?

[samikeijonen]

Hmm I still don't get what it's suppose to do :)

Screenshot:

1. Add button.
2. Align left.
3. Wrap text to on state.
4. Add paragraph.

What's suppose to happen? Should button be in it's own line?

[aduth]

I believe that's what the option is for, to allow you to choose between floated left (with content wrapped) and left-aligned on its own line.

[ZebulanStanphill]

@aduth Perhaps this is an indication that that toggle needs to be renamed? I would have guessed that the "Wrap text" option would toggle whether text inside the button would wrap. (Even though that would be a pretty weird thing to dedicate a toggle to.)

[youknowriad]

Unless I'm missing something, it's not doing anything on the frontend, in that case I agree with @samikeijonen we should remove it or correct the frontend behavior.

[samikeijonen]

Perhaps this is an indication that that toggle needs to be renamed? I would have guessed that the "Wrap text" option would toggle whether text inside the button would wrap

Definitely needs more clear wording. I thought it was about text inside the button.

Actually another issue for me is that even if I toggle Wrap text on, update, then refresh the page, and the setting is not saved at all. Maybe that's the real issue here and therefore doesn't do anything for me.

[samikeijonen]

This should be fixed in #7110.