fix: Update wordcount package to prevent crash #6644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like there are some unexpected changes in package-lock.json. Which version of npm do you use? There are some weird things going on when using npm 5 and 6, we have just landed the change which enforces npm 6 to sort it out. |
|
Ah, I’m using nvm but maybe I messed it up. I’m coming from a lot of yarn usage ;-)
I’ll make sure all the node settings are right and push this again.
- Matt (Sent from mobile)
… On 9 May 2018, at 09:52, Grzegorz (Greg) Ziółkowski ***@***.***> wrote:
It seems like there are some unexpected changes in package-lock.json. Which version of npm do you use? There are some weird things going on when using npm 5 and 6, we have just landed the change which enforces nom 6 to sort it out.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Prevent crash on empty wordcount (fix #6617) See: WordPress/packages#122
tofumatt
force-pushed
the
fix/6617-editor-crash-content-empty
branch
from
fba864b
to
d35f9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent crash on empty wordcount (fix #6617)
See: WordPress/packages#122
Description
Bump the
wordcountpackage to fix #6617.How has this been tested?
Tested locally and the crash is gone.
The package itself now has tests to make sure this bug won't happen again.
Screenshots
Types of changes
Bug fix.
Checklist: