Bump React to 16.3.2 to fix IE11 warning #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 16.3.2 uses the `Map( iterable )` constructor to create a map of valid Fragment props. This is a problem in IE11 because IE11 supports a form of Map but not the constructor taking the iterable. The result is that the map is empty and React warns that `children` is not a valid Fragment prop. React 16.3.1 and later contain a fix for this, and I'm bumping to React 16.3.2 as the latest 16.3 version.
4 tasks
aduth
approved these changes
May 10, 2018
There was a problem hiding this comment.
May bring a nice performance boost as well: facebook/react#12510 Curious if this is where the noticeable regression in development lately had started.
Confirmed appears to work well in IE11 and Chrome.
Travis seems grumpy today, probably a false positive (failing to install PHP?).
Do we need to update URLs in class-vendor-script-filename-test.php as well?
Otherwise LGTM 👍
gziolo
added
the
Framework
|
Travis complains about PHP 5.2 targeted build, but everything looks good. Moving on regardless. |
Done wite e1990eb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps our React version to 16.3.2 to address the following warning seen in IE11:
React 16.3.2 uses the
Map( iterable )constructor to create a map of valid Fragment props. This is aproblem in IE11 because IE11 supports a form of Map but not the constructor taking the iterable. The result is that the map is empty and React warns that
childrenis not a valid Fragment prop. React 16.3.1 and later contain a fix for this, and I'm bumping to React 16.3.2 as the latest point release.The React issue:
facebook/react#12500
The fix:
facebook/react#12504
How has this been tested?
Checklist: