Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a new hover and select approach to improve nested block selection #6773

Merged
merged 14 commits into from Jun 1, 2018

Commits on May 30, 2018

  1. Alternate hover approach WIP

    Joen Asmussen committed May 30, 2018
    Copy the full SHA
    44ca18f View commit details
    Browse the repository at this point in the history
  2. Show outline on parent blocks

    youknowriad authored and Joen Asmussen committed May 30, 2018
    Copy the full SHA
    12be2f9 View commit details
    Browse the repository at this point in the history
  3. Block List: Remove unused variables

    aduth authored and Joen Asmussen committed May 30, 2018
    Copy the full SHA
    aa2ea9f View commit details
    Browse the repository at this point in the history
  4. Block Breadcrumb: Render arrow as RTL compatible

    aduth authored and Joen Asmussen committed May 30, 2018
    Copy the full SHA
    62d412e View commit details
    Browse the repository at this point in the history
  5. Writing Flow: Force tab stop at focusable wrapper when inner blocks e…

    …xist
    aduth authored and Joen Asmussen committed May 30, 2018
    Copy the full SHA
    1d2ca61 View commit details
    Browse the repository at this point in the history
  6. Inner Blocks: Show overlay for small screen, unselected root block

    aduth authored and Joen Asmussen committed May 30, 2018
    Copy the full SHA
    a31b30d View commit details
    Browse the repository at this point in the history
  7. Try a refined approach to drag and drop

    This commit changes how drag and drop works, so that nested blocks do not have any invisible side affordance for the grabby handle. You can still use the inner padding for dragging, and in a separate enhancement we should make the hover label draggable.
    
    This makes it easier to select the parent block, by allowing you to click the available space below the side UI to select the parent.
    
    Kinda.
    
    There is still an affordance for hovering the side of the block to access the side UI (movers, settings, trash), and this extends the height of 4 stacked buttons on the side. If you hover the area below that, yes you can click the thing below.
    
    This is a balancing act, and I'd like for you to try this. The branch has been thoroughly rebased and squashed prior to this to make it easy to undo this change if it doesn't feel right.
    Joen Asmussen committed May 30, 2018
    Copy the full SHA
    7488a96 View commit details
    Browse the repository at this point in the history
  8. Fix the empty appender in more than columns block

    The empty appender, when on mobile, or in a nested block, shows a reduced version. Previously this was only in the columns block, now it's any block that uses nested children.
    Joen Asmussen committed May 30, 2018
    Copy the full SHA
    696ce2f View commit details
    Browse the repository at this point in the history
  9. Tune hover label again.

    Joen Asmussen committed May 30, 2018
    Copy the full SHA
    feaa3f0 View commit details
    Browse the repository at this point in the history
  10. Fix rebase issue.

    Joen Asmussen committed May 30, 2018
    Copy the full SHA
    9bb97aa View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    f527cf4 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    8e12ea7 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    3bcec0f View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2018

  1. Address feedback.

    Add border to switcher component instead.
    
    Add comment to explain z index.
    Joen Asmussen committed Jun 1, 2018
    Copy the full SHA
    29e1792 View commit details
    Browse the repository at this point in the history