New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding `ServerSideRender` information #6838

Merged
merged 3 commits into from May 25, 2018

Conversation

Projects
None yet
3 participants
@johndyer
Contributor

johndyer commented May 18, 2018

Description

Added <ServerSideRender> (2.8) example.

How has this been tested?

Tested using create-guten-block

Screenshots

Types of changes

Additional explanation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

johndyer and others added some commits May 18, 2018

Adding `ServerSideRender` information
New `ServerSideRender` (2.8) example.

@danielbachhuber danielbachhuber requested a review from westonruter May 21, 2018

@danielbachhuber danielbachhuber added this to the 3.0 milestone May 21, 2018

@danielbachhuber

👍 Looks like a good start to me. Requesting a second review from @westonruter and/or @miina to see if there's anything they'd like to include

## Live rendering in Gutenberg editor
Gutenberg 2.8 added the [`<ServerSideRender>`](https://github.com/WordPress/gutenberg/tree/master/components/server-side-render) block which enables all the rendering to take place on the server using PHP rather than in JavaScript.

This comment has been minimized.

@westonruter

westonruter May 21, 2018

Member

I think this should make note of the fact that the ServerSideRenderer is going to be discouraged in favor of using client-side rendering in JS when possible due to the improved user experience. See https://github.com/WordPress/gutenberg/blob/master/components/server-side-render/README.md

This comment has been minimized.

@danielbachhuber

danielbachhuber May 23, 2018

Member

Good point, updated in 4e8e8be

@danielbachhuber danielbachhuber merged commit dfb9d47 into WordPress:master May 25, 2018

2 checks passed

codecov/project 46.14% (-0.3%) compared to 2c32794
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment