Improve translatable strings containing "%s" to have a translator comment #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
Internationalization (i18n)
ocean90
previously requested changes
Jun 7, 2018
jorgefilipecosta
force-pushed
the
update/improve-translatable-strings
branch
from
4efdfd1
to
60a9d02
Compare
jorgefilipecosta
changed the title
|
Thank you for explanation @ocean90, the code was updated to use translator comments. |
afercia
reviewed
Jun 7, 2018
| @@ -80,6 +80,7 @@ export class ServerSideRender extends Component { | |||
| <Placeholder><Spinner /></Placeholder> | |||
| ); | |||
| } else if ( response.error ) { | |||
| // translators: %s: error message describing the problem | |||
| return ( | |||
| <Placeholder>{ sprintf( __( 'Error loading block: %s' ), response.errorMsg ) }</Placeholder> | |||
There was a problem hiding this comment.
Not sure if in JS it's the same, but ideally the translators comment should be immediately before the line where it is used e..g.:
<Placeholder>{ sprintf(
// translators: %s: error message describing the problem
__( 'Error loading block: %s' )
@ocean90 ?
There was a problem hiding this comment.
Hi @afercia thank you for referring this, the code was updated now translator comments are immediately before the line where they are used.
jorgefilipecosta
force-pushed
the
update/improve-translatable-strings
branch
from
60a9d02
to
4faa48b
Compare
gziolo
approved these changes
Jun 21, 2018
| @@ -34,6 +34,7 @@ export default function editorMediaUpload( { | |||
| const errorHandler = ( { file, sizeAboveLimit, generalError } ) => { | |||
| let errorMsg; | |||
| if ( sizeAboveLimit ) { | |||
| // translators: %s: file name | |||
There was a problem hiding this comment.
You probably need to move it inside sprintf just before the line with __( ... ).
gziolo
dismissed
ocean90’s stale review
There is no usage of _x() anymore so dismissing this one to unblock PR. @ocean90 feel free to review again.
…bing what %s means.
jorgefilipecosta
force-pushed
the
update/improve-translatable-strings
branch
from
4faa48b
to
9790144
Compare
|
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use %s in a string and it is not totally obvious what %s means when reading the rest of the string, we should provide a translator comment.
Tries to address: #5361
How has this been tested?
Only comments were added to the translations was added in this changes, some smoke testing, and the automated tests should be enough to catch problems.