React: Enable Strict Mode #7202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be in favor of doing it, it will help to avoid using deprecated lifecycle methods which are going to be renamed (or fully removed) as of React 17. |
The last item on the list might be the biggest issue in our case ... |
|
Should we also update to React 16.4.x in the same PR? There shouldn't be any breaking changes. I think we can move on with this one as it starts to be noisy only when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for Future React updates (Async mode), let's enable StrictMode in dev mode to avoid using deprecated APIs in Core and plugins.
This will create a ton of warnings in the console at the moment, but we should make sure to fix them in follow-up PRs.