New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Core Data Module to the reusable packages #7222

Merged
merged 3 commits into from Jun 8, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Jun 8, 2018

Moving this package is straightforward, no real complications here :)

Testing instructions

  • Gutenberg loads as expected.

@youknowriad youknowriad requested a review from gziolo Jun 8, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Jun 8, 2018

README file should contain some details how to install package from npm.

We usually update Jest config altogether with moving it to packages in here: https://github.com/WordPress/gutenberg/blob/master/test/unit/jest.config.json#L4-L9. I'm wondering why it didn't break any tests. It is very likely that @wordpress/core-data is never imported for tests.

@gziolo

There are two small things to fix and we should be good to go.

@gziolo gziolo added the Packages label Jun 8, 2018

@gziolo gziolo added this to the 3.1 milestone Jun 8, 2018

@gziolo

gziolo approved these changes Jun 8, 2018

Great work, we have another one ready to publish 💯

@Shelob9 Shelob9 referenced this pull request Jun 8, 2018

Closed

Packages: Publish all modules as independent npm packages #3955

19 of 19 tasks complete

@youknowriad youknowriad merged commit a9fab4d into master Jun 8, 2018

2 checks passed

codecov/project 46.69% remains the same compared to c7ce08b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the add/core-data-package branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment