New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end 2 end test to blocks.BlockEdit filter #7294

Merged
merged 5 commits into from Jun 13, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Jun 12, 2018

Description

Test PR adds and e2e test to blocks.BlockEdit. We test a sample plugin that adds a Reset Block button in the inspector to all blocks. When pressed this button resets a block to the default values.

How has this been tested?

I Verified the new end 2 end passes with success and that the test plugin works well.

gziolo added some commits Jun 13, 2018

@gziolo

gziolo approved these changes Jun 13, 2018

I pushed a few tweaks myself to speed up things. My changes includes:

  • some formatting changes to match with plugins api tests
  • I wrapped the reset button with PanelBody to make it look better visually
  • I fixed deps provided in wp_enqueue_script declaration
  • Renamed a few things and explicitly passed only those props that are used in ResetBlockButton

@jorgefilipecosta great job adding those tests, they work great on my local env and example is excellent 💯

@gziolo gziolo merged commit 0f981f7 into master Jun 13, 2018

2 checks passed

codecov/project 46.67% (-0.05%) compared to 4d3e3f6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the add/e2e-test-blocks.BlockEdit-filter branch Jun 13, 2018

@jorgefilipecosta jorgefilipecosta added this to the 3.1 milestone Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment