Add end 2 end test to blocks.BlockEdit filter #7294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Automated Testing
gziolo
approved these changes
Jun 13, 2018
There was a problem hiding this comment.
I pushed a few tweaks myself to speed up things. My changes includes:
- some formatting changes to match with plugins api tests
- I wrapped the reset button with
PanelBodyto make it look better visually - I fixed deps provided in
wp_enqueue_scriptdeclaration - Renamed a few things and explicitly passed only those props that are used in
ResetBlockButton
@jorgefilipecosta great job adding those tests, they work great on my local env and example is excellent 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test PR adds and e2e test to blocks.BlockEdit. We test a sample plugin that adds a Reset Block button in the inspector to all blocks. When pressed this button resets a block to the default values.
How has this been tested?
I Verified the new end 2 end passes with success and that the test plugin works well.