Upgrade React 16.3.2 to React 16.4.1 #7393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
previously requested changes
Jun 20, 2018
package.json
Outdated
| @@ -44,12 +44,12 @@ | |||
| "prop-types": "15.5.10", | |||
| "querystringify": "1.0.0", | |||
| "re-resizable": "4.4.8", | |||
| "react": "16.3.2", | |||
| "react": "^16.4.1", | |||
There was a problem hiding this comment.
Why the change to using caret? Locking down package versions as tightly as possible is a good idea, so I think this should be changed to 16.4.1 over ^16.4.1.
package.json
Outdated
| "react-autosize-textarea": "3.0.2", | ||
| "react-click-outside": "2.3.1", | ||
| "react-color": "2.13.4", | ||
| "react-datepicker": "1.4.1", | ||
| "react-dom": "16.3.2", | ||
| "react-dom": "^16.4.1", |
|
@tofumatt Ah yes, excuse me. I fixed it. |
gziolo
requested changes
Jun 20, 2018
packages/element/package-lock.json
Outdated
| @@ -0,0 +1,146 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should be removed. We don't want to maintain package lock files for individual packages. It's a bug with Lerna that it doesn't respect .npmrc file ... I observe that it happens where you run npm install when there are 2 different versions of the package in two package.json files.
gziolo
added
the
Framework
gziolo
approved these changes
Jun 20, 2018
|
Sidenote: we probably should start using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates react from version 16.3.2 to version 16.4.1.
Reason for this PR is because I would like to use
react-test-rendererfor testing components that use React's newforwardReffeature, which is not supported by enzyme. As you can read in the changelog for React 16.4, support for usingreact-test-rendererwithforwardRefwas added in this version.Not being able to test components with
forwardRefis currently blocking #6261.Since this is a minor version bump no breaking changes are to be expected, and while testing this I did not encounter any unexpected behaviour.
How has this been tested?
The unit tests still work.
Screenshots
Types of changes
New feature.
Checklist: