Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filler spaces from empty constructs. #8169

Merged

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jul 24, 2018

Quick coding standards PR to remove filler spaces in empty constructs.

Note:
One of them was in a test file, removed anyway to strip any occurrences from the codebase.

@afercia afercia requested a review from gziolo July 24, 2018 14:13
@afercia
Copy link
Contributor Author

afercia commented Jul 24, 2018

P.S. not my area of expertise, but maybe it would be nice to have an ESLint rule for this?

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Soean Soean added this to the 3.4 milestone Jul 26, 2018
@pento pento modified the milestones: 3.4, 3.5 Jul 30, 2018
@gziolo gziolo added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 30, 2018
@gziolo gziolo force-pushed the update/coding-standards-no-filler-spaces-empty-constructs branch from 574d2d7 to 54458a9 Compare August 1, 2018 09:03
@gziolo gziolo merged commit 2644033 into master Aug 1, 2018
@gziolo gziolo deleted the update/coding-standards-no-filler-spaces-empty-constructs branch August 1, 2018 09:04
@aduth
Copy link
Member

aduth commented Aug 9, 2018

I would have thought there'd be an existing ESLint rule to allow this to be configured, but alas, it doesn't seem currently supported. Or, more specifically, we already have array-bracket-spacing and object-curly-spacing set to always, but while these ensure whitespace exists when members are present, they don't error when whitespace exists unnecessarily (no members).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants