Update Dashicons component. #8811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a few new icons, notably Insert Before and Insert After. But it also adds any dashicons that have been added to the upstream repo in the mean time.
talldan
reviewed
Aug 10, 2018
| @@ -6,10 +6,15 @@ OR if you're looking to change now SVGs get output, you'll need to edit strings | |||
| !!! */ | |||
|
|
|||
| /** | |||
| * WordPress dependencies | |||
| * External dependencies | |||
There was a problem hiding this comment.
This one should be a WordPress dependency
This is also accompanied by an upstream PR to the Dashicons repo.
|
This PR is updated to the new Gutenberg styles. I've also submitted WordPress/dashicons#312 to take care of it upstream. |
aduth
approved these changes
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few new icons, notably Insert Before and Insert After.
But it also adds any dashicons that have been added to the upstream repo in the mean time.
I see changes have been added in 6928e41#diff-297ebddffcddddf088a365bab7f0909cR9, but they have not been added upstream.
Are those changes intentional, because if yes let's backport them to the upstream repo, then I can redo this PR.
I can do the backporting PR, but please remember that the Dashicon component is built using a build process in a separate repo: https://github.com/WordPress/dashicons