Data: Add RegistryConsumer export #9042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin code relies on the RegistryProvider to be able to add functionality to the registry. `withSelect` uses the RegistryConsumer, but code outside of `@wordpress/data` can't access this modified registry at all (even though it can create it!). This solves the incongruence by simply exporting RegistryConsumer as well.
|
I think we didn't know if people were going to create alternative HoCs instead of |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plugin code relies on the RegistryProvider to be able to add
functionality to the registry.
withSelectuses the RegistryConsumer,but code outside of
@wordpress/datacan't access this modifiedregistry at all (even though it can create it!).
This solves the incongruence by simply exporting RegistryConsumer as
well.
How has this been tested?
It's just an export so adding a test doesn't really make sense.
However, I have tested the export by using it here: woocommerce/woocommerce-admin#301
Types of changes
This isn't really a new feature and not quite a bug fix, but more an enhancement or correction.
It is not a breaking change.
Checklist: