Make Archives Block display correct empty message

[caxco93]

Description

When creating an Archives Block while having no posts published, the
Archives Block is empty and overlaps with the subsequent Blocks.

This addresses that by setting the correct Block content when there
are no Archives to show.

How has this been tested?

Built in tests and manually

Screenshots

Before:

After:

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

Fixes #9418

[jorgefilipecosta]

We are outputting an empty class on the frontend <div class="">No archives to show.</div>. Should we use esc_attr( $class ) here instead of $classnames ?

[caxco93]

Thanks for noticing!

[pento]

@caxco93: Thanks for the PR!

It seems like this could be simplified further: rather than duplicating the sprintf() call, it could be something like:

$block_content = sprintf(
	'<ul class="%1$s">%2$s</ul>',
	esc_attr( $class ),
	$archives ? $archives : __( 'No archives to show.', 'gutenberg' )
);

[caxco93]

Yeah it could be simplified with something along those lines, but with that example you gave we would have an ul with only text inside when there are no archives.

This was actually based on a similar implementation for the empty Comments Block, but now that you point this out, I think that we should stick to a simple if ( empty ) ... else for readability.

what do you think @pento ?

[pento]

Oh, I totally missed the <ul> / <div> difference. 🙂

This looks good to me, thanks @caxco93!

[karmatosed]

Just a little note, we probably should have had a design check on this but we can retro do. In future as this is a state lets get insight here.