Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set aspect ratio preserving CSS on embedded content with fixed size iframes #9500

Merged
merged 10 commits into from Sep 7, 2018
Merged

Set aspect ratio preserving CSS on embedded content with fixed size iframes #9500

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9255d29
Set aspect ratio preserving CSS on previews with fixed size iframes
notnownikki Aug 31, 2018
5baab35
Add aspect ratio CSS.
Sep 4, 2018
fdfa437
Add embed wrapper div in saved content for responsive classes
notnownikki Sep 4, 2018
3720784
Fix things up.
jasmussen Sep 4, 2018
a81372e
Remove the aspect ratio preservation from sandbox
notnownikki Sep 4, 2018
f75ac26
Fix embed tests
notnownikki Sep 4, 2018
6ed5c58
Fix for responsiveness in the editor also.
jasmussen Sep 4, 2018
27c15c7
Fix height for video sandboxing
notnownikki Sep 4, 2018
ea6d484
Make the aspect ratio generic again
notnownikki Sep 4, 2018
037607d
Fix review points
notnownikki Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/src/sandbox/index.js
View file
Open in desktop
Expand Up @@ -137,8 +137,12 @@ class Sandbox extends Component {
body {
margin: 0;
}
html,
body,
body > div,
body > div > iframe {
width: 100%;
height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this height property is necessary in order for the responsiveness to work, basically because every element that contains the embed needs an explicit height in order for a single percentage height to work properly.

But if this component is used for things that aren't aspect ratio responsive, we need to scope it. Something like:

html.is-video,
html.is-video body,
html.is-video body > div,
html.is-video body > div > iframe {
height: 100%;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see :) Ok, I'll see how it can be changed around to only get applied to things we're doing aspect ratio preservation on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to send this PR right back at me if we can have a CSS class or separate style declaration for aspect ratio responsive stuff only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool to have an .is-responsive or .has-aspect-ratio class to target here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I was thinking .wp-embed-has-aspect-ratio and then the editor should be able to use that to apply the height to the sandbox iframe.

}
body > div > * {
margin-top: 0 !important; /* has to have !important to override inline styles */
Expand Down