Move video caption styles to style.scss #9600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The theme.scss file exists to let themes opt into opinionated styles. However caption styles using the new figcaption markup are unlikely to be styled by themes. Therefore it should be in style.scss or it will look broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme.scss file exists to let themes opt into opinionated styles.
However caption styles using the new figcaption markup are unlikely to be styled by themes. Therefore it should be in style.scss or it will look broken.
In addition to adding the caption styles back, this PR neutralizes the left and right margin on the video block that the
figurecomes born with.Frontend:
Backend: