New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move video caption styles to style.scss #9600

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Sep 4, 2018

The theme.scss file exists to let themes opt into opinionated styles.

However caption styles using the new figcaption markup are unlikely to be styled by themes. Therefore it should be in style.scss or it will look broken.

In addition to adding the caption styles back, this PR neutralizes the left and right margin on the video block that the figure comes born with.

Frontend:

frontend

Backend:

backend

Move video caption styles to style.scss
The theme.scss file exists to let themes opt into opinionated styles.

However caption styles using the new figcaption markup are unlikely to be styled by themes. Therefore it should be in style.scss or it will look broken.

@jasmussen jasmussen added this to the 3.8 milestone Sep 4, 2018

@jasmussen jasmussen self-assigned this Sep 4, 2018

@jasmussen jasmussen requested a review from kjellr Sep 4, 2018

@youknowriad

LGTM 👍

@jasmussen jasmussen merged commit 44f83b0 into master Sep 5, 2018

2 checks passed

codecov/project 50.36% remains the same compared to cf74b67
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the add/video-caption-styles branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment