Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the URL Input label to match Classic #9893

Merged
merged 4 commits into from Oct 4, 2018
Merged

Change the URL Input label to match Classic #9893

merged 4 commits into from Oct 4, 2018

Conversation

pento
Copy link
Member

@pento pento commented Sep 14, 2018

Description

The current URL input label "Paste URL or type" doesn't actually say what typing does, and it hides the ability to search for posts/pages to link to.

Changing it to match the label in Classic, "Paste URL or type to search" tells the author what it is that typing will do, and makes the search functionality more discoverable.

In order to make the longer label fit, this change increases the width of the URL input box.

Screenshots

url input in Gutenberg

url input in classic

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@pento pento added the Needs Design Feedback Needs general design feedback. label Sep 14, 2018
@pento pento added this to the 3.9 milestone Sep 14, 2018
@pento pento self-assigned this Sep 14, 2018
@pento pento requested a review from a team September 14, 2018 06:47
@youknowriad
Copy link
Contributor

The UrlLink button is always a tricky component to tweak.

I noticed some regressions on this PR

screen shot 2018-09-14 at 10 27 23

screen shot 2018-09-14 at 10 27 57

Also, I think it's probably better to keep the smaller size for mobile.

@youknowriad
Copy link
Contributor

I'm moving this PR to 4.0 feel free to merge though if it makes the 3.9 cut

@youknowriad youknowriad modified the milestones: 3.9, 4.0 Sep 14, 2018
@jorgefilipecosta
Copy link
Member

@youknowriad thank you for the feedback, @pento and I have fixed those visual bugs and restricted the width increases to non-mobile devices.

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a code point of view, but I noticed this overlapping is quite pronounced now, so would prefer if a designer decided whether to approve the change:

screen shot 2018-10-04 at 12 27 15 pm

It does also happen in master, but not to the same degree. The popover does have some logic to stop it escaping the browser window's bounding box - maybe it's possible to change that so that it stays within the editor's bounding box instead.

@tofumatt
Copy link
Member

tofumatt commented Oct 4, 2018

Note that a submenu will enter the editor bounding box and cause the issue of a popover appearing over it too. 🤷‍♂️

Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overlap is already an issue that needs fixing and this is definite usability improvement.

I'd welcome design thoughts but they shouldn't be a blocker for this issue. I say 🚢 and we can improve the overlap in a follow-up issue.

@jasmussen
Copy link
Contributor

Yep. If this works fine on mobile, then go for it.

@gziolo gziolo merged commit 27a4cea into master Oct 4, 2018
@gziolo gziolo deleted the fix/link-label branch October 4, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants