Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update dependency packages #71

Closed
wants to merge 4 commits into from
Closed

Update dependency packages #71

wants to merge 4 commits into from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 5, 2021

This PR updates some dependencies after updating the Python version to 3.9. It is based on the #72, and includes its changes. It fixes several issues created from dependabot PRs when we transferred the repository.

To create this PR, I installed the dependencies into a virtual environment within the Docker cccatalog-api container. I ran pipenv update <package-name> to update the version. Some versions were higher than the ones in dependabot PRs, and they are shown in bold in the list below. Then I copied the resulting Pipfile.lock file to the repository on my computer, stopped Docker containers, and re-built them with the new Pipfile. After loading sample data, I ran the tests and all the tests passed.

Fixes #29 jinja2 2.11.2 -> 2.11.3
Fixes #33 pycodestyle 2.6.0 ->2.7.0
Fixes #34 deepdiff 5.0.2 [->5.2.1] -> 5.5.0
Fixes #39 pipdeptree 1.0.0 -> 2.0.0
Fixes #41 django-storages 1.10.1 -> 1.11.1
Fixes #43 pyjwt 1.7.1 [-> 2.0.1] -> 2.1.0
Fixes #44 djangorestframework 3.11.1 -> 3.12.4
Fixes #48 hvac 0.10.5 [-> 0.10.8] -> 0.10.10
Fixes #49 boto3 1.15.11 [-> 1.17.39] -> 1.17.67
Fixes #50 gevent 20.9.0 [-> 21.1.0] -> 21.1.2
Fixes #51 py 1.9.0 -> 1.10.0
Fixes #52 ipython 7.18.1 [-> 7.21.0] -> 7.23.1
Fixes #54 pygments 2.7.1 [-> 2.7.4] -> 2.9.0

Note: I did not update django (#40) in this PR

obulat added 4 commits May 5, 2021 09:31
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat requested a review from dhruvkb May 5, 2021 12:08
@dhruvkb dhruvkb added this to Needs review in Openverse May 5, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me. @dhruvkb could you please review too? You have a good eye for dependency changes

Openverse automation moved this from Needs review to Reviewer approved May 5, 2021
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obulat let's change the target branch of this PR to obulat:python_update_to_3.9 (same as #70) and merge it. That way we can test the combined effects of the upgrade to Python 3.9.

Verified that the updated dependencies are working fine.

@obulat
Copy link
Contributor Author

obulat commented May 6, 2021

All of the changes in this PR are contained in #72. Closing this PR in favor of a more comprehensive one.

@obulat obulat closed this May 6, 2021
Openverse automation moved this from Reviewer approved to Done! May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.