This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update packages and add updated Pipfile.lock files #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python 3.9 update has updated the Dockerfiles, but didn't update the
Pipfile.lock
files. With the old lock files, Docker builds fail with the following error:In the Dockerfile, we install the python packages as root using
RUN pipenv install --deploy --system --dev
This uses the existing
Pipfile.lock
, and doesn't update it.To update the
Pipfile.lock
I addedRUN pipenv install --dev
to the Dockerfile. It installed dependencies into a virtual environment, and updated thePipfile.lock
accordingly. Then I copied the updated Pipfile.lock from docker to my computer usingdocker cp openverse-api_ingestion-server_1:/ingestion_server:Pipfile.lock ~/<path_to_repo>/ingestion_server/Pipfile.lock
command. This process worked for ingestion server and analytics.In the
cccatalog-api
, the copiedPipfile.lock
file was the old one. So, I had to runpipenv install
inside the docker container shell (I used the Docker Desktop's 'CLI' button for the container), and then copy the updatedPipfile.lock
using thedocker cp
command described in the previous paragraph.While updating the Pipfiles, pipenv also updated other dependencies listed in #71, so I am closing it in favor of this PR.
Several issues created from dependabot PRs when we transferred the repository are fixed:
Fixes #29 jinja2 2.11.2 -> 2.11.3
Fixes #33 pycodestyle 2.6.0 ->2.7.0
Fixes #34 deepdiff 5.0.2 [->5.2.1] -> 5.5.0
Fixes #39 pipdeptree 1.0.0 -> 2.0.0
Fixes #41 django-storages 1.10.1 -> 1.11.1
Fixes #43 pyjwt 1.7.1 [-> 2.0.1] -> 2.1.0
Fixes #44 djangorestframework 3.11.1 -> 3.12.4
Fixes #48 hvac 0.10.5 [-> 0.10.8] -> 0.10.10
Fixes #49 boto3 1.15.11 [-> 1.17.39] -> 1.17.67
Fixes #50 gevent 20.9.0 [-> 21.1.0] -> 21.1.2
Fixes #51 py 1.9.0 -> 1.10.0
Fixes #52 ipython 7.18.1 [-> 7.21.0] -> 7.23.1
Fixes #54 pygments 2.7.1 [-> 2.7.4] -> 2.9.0
The dependency graph after these changes